Fix scaling of vector space morphisms on the left#37709
Open
mkoeppe wants to merge 7 commits intosagemath:developfrom
Open
Fix scaling of vector space morphisms on the left#37709mkoeppe wants to merge 7 commits intosagemath:developfrom
mkoeppe wants to merge 7 commits intosagemath:developfrom
Conversation
tscrim
requested changes
Apr 3, 2024
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
I believe you still need a test to check that right (now other) is a MatrixMorphism. The coercion only guarantees that they have the same parent, but homspaces can use multiple types of element classes.
Collaborator
|
I am pretty sure you pushed things to the wrong branch with the last two commits. |
Contributor
Author
|
No, I used it as a test case for: |
Collaborator
|
I see. Well, then until this is a clean branch, I will hold off on finishing the review. |
|
Documentation preview for this PR (built with commit 798a69c; changes) is ready! 🎉 |
added 7 commits
August 3, 2024 11:34
…t_constructor_, not __call__
…estore isinstance test, add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a rebased version of the first commit (328125f6292de28326dda0e2497c2474aa54c7b7 from #28272 by @tscrim
📝 Checklist
⌛ Dependencies