threejs feature: include version file in sagemath-environment#37380
Closed
tornaria wants to merge 1 commit intosagemath:developfrom
Closed
threejs feature: include version file in sagemath-environment#37380tornaria wants to merge 1 commit intosagemath:developfrom
tornaria wants to merge 1 commit intosagemath:developfrom
Conversation
Contributor
|
This is not a good change, see discussion in #37024 |
This makes the feature complete when only sagemath_environment is installed. Fixes: sagemath#37178
448d380 to
02d8440
Compare
Member
Author
|
This is working fine now. The version file is moved as package data in |
Contributor
No, this has the same problem. I'll explain in more detail by Monday, OK? (Edit: There's always a "next" Monday...) |
|
Documentation preview for this PR (built with commit 02d8440; changes) is ready! 🎉 |
5 tasks
Contributor
|
This issue was resolved by #37178, and is now irrelevant anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37178
@mkoeppe @kwankyu