deprecated functions is_Cone, is_Polyhedron, is_LatticePolytope#37057
Merged
vbraun merged 6 commits intosagemath:developfrom May 2, 2024
Merged
deprecated functions is_Cone, is_Polyhedron, is_LatticePolytope#37057vbraun merged 6 commits intosagemath:developfrom
vbraun merged 6 commits intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 35ff879; changes) is ready! 🎉 |
Collaborator
Contributor
|
This PR is missing the changes from #37052 that rewrite the uses of these newly deprecated functions by |
Contributor
|
Cherry-picked from #37052. |
tscrim
approved these changes
May 1, 2024
Collaborator
tscrim
left a comment
There was a problem hiding this comment.
Green bot => positive review.
Contributor
|
Thanks, Travis! Now it's green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<deprecated 3 functions is_Cone, is_Polyhedron, is_LatticePolytope>
< The change will issue a warning when the functions are used that will inform the user about the functions being deprecated and to use a different instead>
<Fixes #34307>
📝 Checklist
⌛ Dependencies