CI Linux incremental: Set max_parallel = 8, reduce standard-sitepackages platforms#36697
Conversation
tobiasdiez
left a comment
There was a problem hiding this comment.
Can we please try it first with my initial suggestion, before we loose ourself in optimizing to find a local minima.
|
This change here is for the incremental build on PRs that make changes to packages. |
|
Yes, I can read. But it also changes the load on the github actions so comparison with previous releases will get harder. For this reason, I propose the following strategy:
|
As I just wrote over in #36610, you can just run that in your own repo and report back. |
883e05f to
e349b00
Compare
…uce platforms tested with standard-sitepackages
|
@orlitzky Objections or other comments on reducing the tested sitepackages platforms? |
I agree. Having them fail repeatedly doesn't make sense without someone actively working on them. |
Let's wait until the fine-tuning PR and also this PR gets merged.
Using ~4 hours until "default" is built to finish as many "standard" jobs as possible is an objective rather than a means. If the problem (PR jobs gets no chance) persists after the ~4 hours, then, I think, your PR should focus on improving the situation after the ~4 hours. |
|
Thanks! |
|
Documentation preview for this PR (built with commit 5ac6d13; changes) is ready! 🎉 |
|
I'm a big fan of the content of this PR, but as I've explained above I think its to early to merge it.
Please don't rewrite the history. The purpose of #36610 is clearly stated "Currently, the ci-linux workflow runs a lot of parallel runs which prevents other workflows (from PR) to be executed. We add a few more max_parallel statements to spread the stress on the ci over a longer time." (i.e improve the execution time for PR workflows). In #36616 (comment) you reviewed Matthias PR with the words "Both of you proposed solutions of the same problem." I don't know why it's so hard to admit that Matthias' idea, while being a good one, completely failed to improve the situation for PR workflows. But anyway, this is not very relevant to this PR. |
|
Note that this PR was not set to "blocker", so it won't merged until the 10.3 release cycle anyway. |
I have to point out that comparing the runs is very difficult when the CI Linux Incremental workflow puts these heavy workloads in the queue. So if there is a real interest in making a decision based on observations / data, we need to do what is done here in the PR first. |
Yes. I understood that.
Yes. But as I said in #36616 (comment), I realized that Matthias has the objective (finish early as many "standard" jobs as possible) as well as "the same problem", but you are not sharing this.
He is still fine-tuning his idea. Why it's so hard to wait for himself to admit his ultimate failure? |
|
Let's move forward here. |
|
I see no meaningful objection here, so let's merge this. |
I don't think this is how it's supposed to work. |
|
@tobiasdiez Here on this PR you have not even raised a reviewer concern. It has been positively reviewed. You are just demanding that something else is merged first -- the PR #36610, which does not have any support. But when something is merged is up to the release manager to decide. |
|
Still to early in my opinion. I would be fine with setting it to "pending" and "positive-review" (as a signal to the release manager that it should not yet be merged), but in the absence of such a mechanism I'll remove the positive review label again. |
|
All of what is written in #36697 (comment) is moot, and you are not giving any reason. |
I do, just because you don't agree with them they are not "moot". |
Where? |
That's correct! That's not the mechanism! They are moot because #36697 (comment) refers to timing some experiments in weeks that have passed, and relative to your PR #36610, which does not have any support. |
To reduce the impact of the PRs that run CI Linux incremental on the GH Actions queue, in particular after a release (for example: https://github.com/sagemath/sage/actions/runs/6827962772)
📝 Checklist
⌛ Dependencies