Skip to content

prompt_toolkit: Set version constraint for conda#36659

Merged
vbraun merged 1 commit intosagemath:developfrom
mkoeppe:prompt_toolkit_conda
Nov 10, 2023
Merged

prompt_toolkit: Set version constraint for conda#36659
vbraun merged 1 commit intosagemath:developfrom
mkoeppe:prompt_toolkit_conda

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Nov 5, 2023

Replaces #36560.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 6, 2023

Documentation preview for this PR (built with commit 7dabb0a; changes) is ready! 🎉

Copy link
Copy Markdown
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only in the conda file and not also in install_requires?

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Nov 7, 2023

Because it's already there

Copy link
Copy Markdown
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Nov 7, 2023

Thanks!

@vbraun vbraun merged commit 781dbff into sagemath:develop Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants