Skip to content

build/pkgs/tox: Update, require tox >= 4.2.7, update dependencies#36176

Merged
vbraun merged 15 commits intosagemath:developfrom
mkoeppe:tox_4
Sep 16, 2023
Merged

build/pkgs/tox: Update, require tox >= 4.2.7, update dependencies#36176
vbraun merged 15 commits intosagemath:developfrom
mkoeppe:tox_4

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Sep 2, 2023

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkoeppe requested changes for this PR


MIT

Upstream Contact
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the license info deleted?


MIT

Upstream Contact
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the license info is deleted? It seems still valid.

@kwankyu
Copy link
Copy Markdown
Collaborator

kwankyu commented Sep 7, 2023

It looks good to me as far as I check.

I will set positive review after Build & Test passes here and locally, unless @orlitzky chimes in.

Copy link
Copy Markdown
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well with me.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Sep 7, 2023

Thank you!

@vbraun
Copy link
Copy Markdown
Member

vbraun commented Sep 10, 2023

merge conflict

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit d4bd789; changes) is ready! 🎉

@kwankyu
Copy link
Copy Markdown
Collaborator

kwankyu commented Sep 14, 2023

Is "Build&Test using Conda" supposed to pass? What should I compare the result with? Does it pass on develop branch?

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Sep 14, 2023

"Build&Test using Conda" has been broken for a while now; a possible fix in #35986 is stuck

@kwankyu
Copy link
Copy Markdown
Collaborator

kwankyu commented Sep 14, 2023

OK then.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Sep 14, 2023

Thanks!

@vbraun vbraun merged commit 5b2f125 into sagemath:develop Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toml package is obsolete Upgrade tox to 4.x

3 participants