Skip to content

Stop sorting Graph vertices and edges by default#36073

Merged
vbraun merged 4 commits intosagemath:developfrom
dcoudert:graphs/stop_sorting_vertices_and_edges
Aug 13, 2023
Merged

Stop sorting Graph vertices and edges by default#36073
vbraun merged 4 commits intosagemath:developfrom
dcoudert:graphs/stop_sorting_vertices_and_edges

Conversation

@dcoudert
Copy link
Copy Markdown
Collaborator

Following #22349 and #27408, we finally set parameter sort to False by default for methods vertices and edges, and remove the corresponding deprecation warnings.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dcoudert
Copy link
Copy Markdown
Collaborator Author

I marked this PR as critical as it would be nice to have it merged in 10.1.

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit c8670bd; changes) is ready! 🎉

Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants