Clear up left right confusion in ore_polynomial_element.pyx#35562
Merged
vbraun merged 4 commits intosagemath:developfrom Jun 3, 2023
Merged
Clear up left right confusion in ore_polynomial_element.pyx#35562vbraun merged 4 commits intosagemath:developfrom
ore_polynomial_element.pyx#35562vbraun merged 4 commits intosagemath:developfrom
Conversation
ore_polynomial_element.pyx
xcaruso
approved these changes
Apr 27, 2023
Contributor
xcaruso
left a comment
There was a problem hiding this comment.
There was a lot of misprints in this documentation. Thanks for catching all of these!
Contributor
|
However, the patchbot (should we continue to use this term?) reports some failures. Should we fix them before giving a positive review? |
Collaborator
Author
|
No. They are not related with this PR. The lint check is being dealt with in other PR, and the codecov/project is plaguing all PRs. Thanks for review! |
Member
|
merge conflict |
|
Documentation preview for this PR (built with commit 2f42904) is ready! 🎉 |
Collaborator
Author
|
Resolved merge conflict |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Fix #35531. While we are at it, I made other minor edits.
📝 Checklist
⌛ Dependencies