Fix doctests with ipython 8.12#35423
Merged
vbraun merged 2 commits intosagemath:developfrom Apr 6, 2023
Merged
Conversation
Member
Author
|
I don't undestand the check failures. They are certainly unrelated to this PR. What confuses me is that #35337 had all checks passed and this PR has just one small commit on top. |
Member
Author
|
I merged with |
Member
|
I agree the failures are unrelated to this. As far as I understand things. I will switch to ipython 8.12.0 sometimes today to look at this properly. |
kiwifb
approved these changes
Apr 4, 2023
Member
kiwifb
left a comment
There was a problem hiding this comment.
Checked it works with both ipython 8.11 and 8.12 without problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
As reported in #35337 (comment), the update to ipython 8.12 introduces some useless output when calling
get_ipython().enable_gui(...)which causes a few doctest failures.This PR silences this output by (temporarily) redirecting stdout to a string.
This is only one commit that sits right on top of e9c3333 from #35337.
📝 Checklist
⌛ Dependencies