sage.categories: Modularization fixes for imports#35279
Merged
vbraun merged 5 commits intosagemath:developfrom Apr 1, 2023
Merged
sage.categories: Modularization fixes for imports#35279vbraun merged 5 commits intosagemath:developfrom
sage.categories: Modularization fixes for imports#35279vbraun merged 5 commits intosagemath:developfrom
Conversation
added 4 commits
March 13, 2023 19:11
… imported for an isinstance test
…ve imports from sage.algebras, sage.matrix into methods
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35279 +/- ##
===========================================
- Coverage 88.62% 88.62% -0.01%
===========================================
Files 2148 2148
Lines 398653 398663 +10
===========================================
- Hits 353308 353307 -1
- Misses 45345 45356 +11
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Documentation preview for this PR is ready! 🎉 |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
We should be able to import Python modules from
sage.categorieseven if implementation modules are not installed; that's the premise of the distribution sagemath-categories.Here we make changes to avoid module-level dependencies on some higher-level functionality, such as symbolic functions, linear algebra, etc.
#35275 takes care of some other imports.
Part of
📝 Checklist
⌛ Dependencies