sage.graphs: Add # optional doctest tags for modularization#35266
Merged
vbraun merged 14 commits intosagemath:developfrom Apr 1, 2023
Merged
sage.graphs: Add # optional doctest tags for modularization#35266vbraun merged 14 commits intosagemath:developfrom
sage.graphs: Add # optional doctest tags for modularization#35266vbraun merged 14 commits intosagemath:developfrom
Conversation
added 8 commits
March 5, 2023 15:04
…date=format:%Y FILE | sort -k2"
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35266 +/- ##
===========================================
+ Coverage 88.57% 88.59% +0.01%
===========================================
Files 2140 2141 +1
Lines 397273 397416 +143
===========================================
+ Hits 351891 352085 +194
+ Misses 45382 45331 -51
... and 28 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
d90a702 to
5324919
Compare
dimpase
reviewed
Mar 14, 2023
| Next, using the spring-layout algorithm:: | ||
|
|
||
| sage: import networkx | ||
| sage: import networkx # optional - sage.groups |
dimpase
suggested changes
Mar 14, 2023
Member
dimpase
left a comment
There was a problem hiding this comment.
please check that sage.groups tags are not placed by mistake, instead of networkx
Contributor
Author
|
Indeed, thanks for catching this |
Contributor
Author
|
I've rebased on top of the dependency #35237 |
Contributor
Author
|
Thanks! |
|
Documentation preview for this PR is ready! 🎉 |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
These tags make it possible/meaningful to doctest
sage.graphseven when some "standard" packages (networkx,numpy, the modularized distribution packaging providingsage.groups) are not installed.# optionaldoctest tags #34998📝 Checklist
⌛ Dependencies
This is just one commit on top of:
sage.features: Addsage.libs.singular, features for standard Python packages #35237