Skip to content

ci-linux: Remove unmaintained local-conda runs#35125

Merged
dimpase merged 1 commit intosagemath:developfrom
mkoeppe:ci_linux_remove_local_conda
Feb 14, 2023
Merged

ci-linux: Remove unmaintained local-conda runs#35125
dimpase merged 1 commit intosagemath:developfrom
mkoeppe:ci_linux_remove_local_conda

Conversation

@mkoeppe
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe commented Feb 14, 2023

📚 Description

These are jobs that run directly on the GH Actions container instead of using Docker.
We remove them.

These jobs have been failing for a long time.
Newer tests for conda-forge have been added in ci-conda.yml, which makes these ones here obsolete.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez
Copy link
Copy Markdown
Contributor

tobiasdiez commented Feb 14, 2023

Shouldn't be then the corresponding part of the tox ini file also be removed? Also, what is the difference between this tox-based conda run and the one in conda-ci?

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 14, 2023

Shouldn't be then the corresponding part of the tox ini file also be removed?

No, the tox.ini can be used locally.

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 14, 2023

what is the difference between this tox-based conda run and the one in conda-ci?

The one removed here builds sage-the-distribution on top of conda-forge. But this mode of installation is also tested using docker-conda-forge, which is more robust because we have more control over this environment than we do over the github actions container.

In contrast, in conda-ci, we use the "experimental" method of running sagelib directly on top of conda-forge.

tobiasdiez
tobiasdiez approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Makes sense!

@mkoeppe
Copy link
Copy Markdown
Contributor Author

mkoeppe commented Feb 14, 2023

Thank you!

@tobiasdiez tobiasdiez changed the title .github/workflows/ci-linux.yml: Remove unmaintained local-conda runs ci-linux: Remove unmaintained local-conda runs Feb 14, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 14, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: e25deb6

@dimpase
Copy link
Copy Markdown
Member

dimpase commented Feb 14, 2023

merging, as it improves CI by removing broken tests

@dimpase dimpase merged commit e310936 into sagemath:develop Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: porting

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mkoeppe @tobiasdiez @dimpase @kwankyu