Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35097 +/- ##
===========================================
+ Coverage 88.60% 88.62% +0.01%
===========================================
Files 2136 2148 +12
Lines 396142 398732 +2590
===========================================
+ Hits 350990 353361 +2371
- Misses 45152 45371 +219
... and 159 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| def _universal_cover_dict(self): | ||
| r""" | ||
| Return the fundamental group and dictionary sending each edge to | ||
| the corresponding group element |
| (f * f * f, e): ((f * f, 1), s_0 (f, e), s_1 (f, e), (f * f, e))} | ||
| sage: C.fundamental_group() | ||
| Finitely presented group < | > | ||
|
|
There was a problem hiding this comment.
I suggest deleting these two blank lines.
jhpalmieri
left a comment
There was a problem hiding this comment.
Overall it looks very good to me. I've suggested a few very minor changes, and one method needs doctests. Then it will be ready to go.
Co-authored-by: John H. Palmieri <jhpalmieri64@gmail.com>
Co-authored-by: John H. Palmieri <jhpalmieri64@gmail.com>
|
Thanks for the review. I did the suggested changes. |
|
Looks great, thank you! |
|
Documentation preview for this PR is ready! 🎉 |
📚 Implementation of finite covers of simplicial sets
Compute the cover of a (based) simplicial set associated to a representation of its fundamental group to a finite group.
Fixes #34886.
📝 Checklist
⌛ Dependencies