Skip to content

Add default devcontainer using conda#35072

Merged
tobiasdiez merged 5 commits intosagemath:developfrom
tobiasdiez:conda-container
Feb 15, 2023
Merged

Add default devcontainer using conda#35072
tobiasdiez merged 5 commits intosagemath:developfrom
tobiasdiez:conda-container

Conversation

@tobiasdiez
Copy link
Copy Markdown
Contributor

@tobiasdiez tobiasdiez commented Feb 11, 2023 •
edited
Loading

📚 Description

Now that VSCode support multiple devcontainer configs, we can add a default config that uses conda (similar to the gitpod config). Closes #34560.

Once this PR is merged, I will enable codespace prebuilds so that one can get a running codespace very quickly without the 40min of build time. Example of such a prebuild run can be found at https://github.com/tobiasdiez/sage/actions/runs/4150784209/jobs/7180663661.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez requested review from kwankyu and mkoeppe and removed request for kwankyu February 11, 2023 11:33
@tobiasdiez tobiasdiez requested a review from kwankyu February 11, 2023 13:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 11, 2023 •
edited
Loading

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (7c91b9d) compared to base (49a0aed).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35072      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396961              
===========================================
- Hits        351678   351653      -25     
- Misses       45283    45308      +25
Impacted Files Coverage Δ
src/sage/data_structures/stream.py 92.41% <0.00%> (-5.06%) ⬇️
src/sage/coding/information_set_decoder.py 97.12% <0.00%> (-1.15%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/modular/arithgroup/congroup_gamma0.py 94.41% <0.00%> (-0.56%) ⬇️
src/sage/graphs/tutte_polynomial.py 93.57% <0.00%> (-0.46%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.40%) ⬇️
src/sage/rings/padics/local_generic.py 90.43% <0.00%> (-0.39%) ⬇️
src/sage/modular/modsym/boundary.py 89.88% <0.00%> (-0.30%) ⬇️
src/sage/matrix/matrix_space.py 89.60% <0.00%> (-0.18%) ⬇️
src/sage/rings/continued_fraction.py 90.46% <0.00%> (-0.17%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 12, 2023

Now that VSCode support multiple devcontainer configs, we can add a default config that uses conda (similar to the gitpod config).

That's great news!

mkoeppe
mkoeppe reviewed Feb 12, 2023
View reviewed changes
mkoeppe
mkoeppe reviewed Feb 12, 2023
View reviewed changes
@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 12, 2023

The devcontainer doesn't build for me and enters recovery mode.

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 12, 2023

The devcontainer doesn't build for me and enters recovery mode.

And what is the error?

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 12, 2023

Do you know where I find the errors after it has sent me to the "recovery container"?

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 12, 2023

They should show up automatically in the recovery container. But you can also show the log using the "Dev Containers: Show Container Log" command.

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 12, 2023 

Downloading and Extracting Packages

Preparing transaction: done
Verifying transaction: done
Executing transaction: done
ERROR conda.core.link:_execute(740): An error occurred while installing package 'conda-forge::mathjax-3.2.2-ha770c72_0'.
Rolling back transaction: done

[Errno 28] No space left on device: '/opt/conda/envs/sage-dev/bin'
()

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 13, 2023

Looks like you run in out of your docker space quota microsoft/vscode-dev-containers#128.

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 13, 2023

The failing run was in the cloud, not on my machine

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 13, 2023

Did you use the 8GB RAM runner? Once we enable prebuilds these limits shouldn't be an issue any more. Can you please try it locally?

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 14, 2023 •
edited
Loading

Locally it works fine. I suppose we can look into the codespaces situation later, so I would set it to positive review after you take care of the documentation

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 14, 2023

Okay, thanks! I've now incorporated your suggestions.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 14, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 7c91b9d

mkoeppe
mkoeppe approved these changes Feb 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mkoeppe
Copy link
Copy Markdown
Contributor

mkoeppe commented Feb 14, 2023

The build & test failure is an unrelated doctest timeout.

@tobiasdiez
Copy link
Copy Markdown
Contributor Author

tobiasdiez commented Feb 15, 2023

Thanks! Merging now as its only dx related.

@tobiasdiez tobiasdiez merged commit fbb4127 into sagemath:develop Feb 15, 2023
@tobiasdiez tobiasdiez deleted the conda-container branch February 15, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwankyu kwankyu Awaiting requested review from kwankyu

1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: major / 3

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

Add devcontainer based on conda

4 participants

@tobiasdiez @codecov-commenter @mkoeppe @kwankyu