Mark unstable tests in klyachko.py due to #32773#35058
Merged
dimpase merged 1 commit intosagemath:developfrom Feb 14, 2023
Merged
Mark unstable tests in klyachko.py due to #32773#35058dimpase merged 1 commit intosagemath:developfrom
dimpase merged 1 commit intosagemath:developfrom
Conversation
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35058 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.01%
===========================================
Files 2136 2136
Lines 396142 396142
===========================================
- Hits 350948 350911 -37
- Misses 45194 45231 +37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mkoeppe
approved these changes
Feb 12, 2023
Contributor
mkoeppe
left a comment
There was a problem hiding this comment.
This seems the right thing to do.
Member
|
OK, any chance it's getting properly fixed? (the code was written by @vbraun, as |
Member
|
let's merge this - it will improve CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
These two test failures occasionally waste a whole CI run. Here we just flag them as random so it can be quickly merged, while #32773 is resolved. Since the issue is already known and reported, there is no point to keep running these tests.
Note that the issue in question has a needs_review patch but according to the comments it only solves one of the two tests.
📝 Checklist