Issue #34949: sage.{categories,matrix,structure}: Replace imports from sage.*.all for namespace packages#35012
Conversation
…tegories_matrix_structure___replace_imports_from_sage___all_for_namespace_packages
Codecov ReportBase: 88.59% // Head: 88.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35012 +/- ##
===========================================
- Coverage 88.59% 88.58% -0.02%
===========================================
Files 2140 2140
Lines 396998 397006 +8
===========================================
- Hits 351740 351700 -40
- Misses 45258 45306 +48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tobiasdiez
left a comment
There was a problem hiding this comment.
Tests fail with
sage -t --random-seed=119552442577065273759575227667889303090 sage/structure/element.pyx # 6 doctests failed
|
I've fixed this and updated all other uses as well. Let's see what Build&Test has to say now. |
|
Turns out the placement of |
tobiasdiez
left a comment
There was a problem hiding this comment.
LGTM. I'll leave this at "needs review" as someone else might want to have a look at it. Feel free to set it to "positive review" in a week or so.
|
Thank you! |
…tegories_matrix_structure___replace_imports_from_sage___all_for_namespace_packages
|
Documentation preview for this PR is ready! 🎉 |
Closes #34949