add .torsion_basis() method to EllipticCurve_finite_field#34982
Merged
vbraun merged 1 commit intosagemath:developfrom Feb 19, 2023
Merged
add .torsion_basis() method to EllipticCurve_finite_field#34982vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34982 +/- ##
==========================================
Coverage ? 88.59%
==========================================
Files ? 2136
Lines ? 396146
Branches ? 0
==========================================
Hits ? 350952
Misses ? 45194
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
There are failing tests, but otherwise this looks good to me. |
c9badc3 to
efb609f
Compare
Member
Author
|
The test failure is unrelated to the changes here. See #35017. |
efb609f to
110d9bf
Compare
Member
|
Looks good to me and tests do now pass -- @roed314 can you do a positive review and change the label accordingly? (I can do the latter, but you are the official reviewer.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34718.