Skip to content

Cross-link matrix methods image and column_space#34972

Merged
vbraun merged 1 commit intosagemath:developfrom
Sandstorm831:u/gh-Sandstorm831/33548
Feb 19, 2023
Merged

Cross-link matrix methods image and column_space#34972
vbraun merged 1 commit intosagemath:developfrom
Sandstorm831:u/gh-Sandstorm831/33548

Conversation

@Sandstorm831
Copy link
Copy Markdown
Contributor

@Sandstorm831 Sandstorm831 commented Feb 6, 2023

This is my pull request originally created on trac, which I thought pushing on github.
Fixes #33548

@Sandstorm831
Copy link
Copy Markdown
Contributor Author

Sandstorm831 commented Feb 6, 2023

Hello everyone, I have created this pull request in view of changes committed by me in the open issue #33548 ,Please tell if anything else needs to be done to merge this pull request.

mezzarobba
mezzarobba reviewed Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. It would be better to keep a single commit with the final version of the changes instead of adding 3 additional useless commits to the history, though.

@Sandstorm831
Copy link
Copy Markdown
Contributor Author

Sandstorm831 commented Feb 8, 2023

Sir I would rebase my branch shortly, actually my system isn't working properly for few days, so it is taking time.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 88.59% // Head: 88.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (0dc758a) compared to base (104dde9).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #34972   +/-   ##
========================================
  Coverage    88.59%   88.59%           
========================================
  Files         2136     2136           
  Lines       396142   396142           
========================================
+ Hits        350948   350953    +5     
+ Misses       45194    45189    -5
Impacted Files Coverage Δ
src/sage/quadratic_forms/random_quadraticform.py 90.00% <0.00%> (-6.00%) ⬇️
src/sage/crypto/util.py 91.37% <0.00%> (-5.18%) ⬇️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/rings/polynomial/pbori/parallel.py 59.82% <0.00%> (-1.79%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/homology/matrix_utils.py 87.15% <0.00%> (-0.92%) ⬇️
src/sage/schemes/elliptic_curves/formal_group.py 93.51% <0.00%> (-0.55%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.42%) ⬇️
src/sage/cpython/_py2_random.py 74.79% <0.00%> (-0.42%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-0.40%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sandstorm831 Sandstorm831 force-pushed the u/gh-Sandstorm831/33548 branch from 3624ad7 to 0dc758a Compare February 9, 2023 08:17
mezzarobba
mezzarobba approved these changes Feb 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mezzarobba mezzarobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vbraun vbraun merged commit 43fcd94 into sagemath:develop Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mezzarobba mezzarobba mezzarobba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: linear algebra p: major / 3 t: enhancement

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

Cross-link matrix methods image and column_space

6 participants

@Sandstorm831 @codecov-commenter @mezzarobba @vbraun @kwankyu @mkoeppe