Skip to content

compute matrix kernels modulo composites#34968

Merged
vbraun merged 3 commits intosagemath:developfrom
yyyyx4:public/matrix_kernels_modulo_composites
Feb 19, 2023
Merged

compute matrix kernels modulo composites#34968
vbraun merged 3 commits intosagemath:developfrom
yyyyx4:public/matrix_kernels_modulo_composites

Conversation

@yyyyx4
Copy link
Copy Markdown
Member

@yyyyx4 yyyyx4 commented Feb 6, 2023

Fixes #34862.

@yyyyx4 yyyyx4 force-pushed the public/matrix_kernels_modulo_composites branch from aaec31a to 27b6732 Compare February 8, 2023 02:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 8, 2023 •
edited
Loading

Codecov Report

Base: 88.58% // Head: 88.58% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (fe50906) compared to base (293dd72).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #34968      +/-   ##
===========================================
- Coverage    88.58%   88.58%   -0.01%     
===========================================
  Files         2140     2140              
  Lines       396961   396961              
===========================================
- Hits        351655   351654       -1     
- Misses       45306    45307       +1
Impacted Files Coverage Δ
...c/sage/geometry/polyhedron/ppl_lattice_polytope.py 96.52% <ø> (ø)
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/graphs/generators/random.py 91.26% <0.00%> (-1.03%) ⬇️
src/sage/modular/modform/numerical.py 94.19% <0.00%> (-0.65%) ⬇️
src/sage/sets/integer_range.py 91.41% <0.00%> (-0.51%) ⬇️
src/sage/graphs/generic_graph.py 89.12% <0.00%> (-0.40%) ⬇️
src/sage/schemes/elliptic_curves/cardinality.py 87.00% <0.00%> (-0.40%) ⬇️
src/sage/graphs/graph_plot.py 84.33% <0.00%> (-0.29%) ⬇️
src/sage/schemes/elliptic_curves/ell_generic.py 93.23% <0.00%> (-0.14%) ⬇️
src/sage/graphs/digraph.py 92.58% <0.00%> (-0.13%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4 yyyyx4 force-pushed the public/matrix_kernels_modulo_composites branch from 27b6732 to fe50906 Compare February 14, 2023 00:20
tscrim
tscrim requested changes Feb 14, 2023
View reviewed changes
@yyyyx4 yyyyx4 force-pushed the public/matrix_kernels_modulo_composites branch from fe50906 to c028ed7 Compare February 15, 2023 16:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 15, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: c028ed7

@yyyyx4
Copy link
Copy Markdown
Member Author

yyyyx4 commented Feb 16, 2023

Thanks for the review!

@vbraun vbraun merged commit 0b88463 into sagemath:develop Feb 19, 2023
@yyyyx4 yyyyx4 deleted the public/matrix_kernels_modulo_composites branch February 20, 2023 03:23
@yyyyx4 yyyyx4 mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

No one assigned

Labels

c: linear algebra p: major / 3 t: enhancement

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

compute matrix kernels modulo composites

6 participants

@yyyyx4 @codecov-commenter @tscrim @vbraun @kwankyu @mkoeppe