Skip to content

Add doctest for #20847#34963

Merged
vbraun merged 1 commit intosagemath:developfrom
mezzarobba:test-20847
Feb 19, 2023
Merged

Add doctest for #20847#34963
vbraun merged 1 commit intosagemath:developfrom
mezzarobba:test-20847

Conversation

@mezzarobba
Copy link
Copy Markdown
Member

@mezzarobba mezzarobba commented Feb 6, 2023 •
edited
Loading

Closes #20847.

@mezzarobba mezzarobba mentioned this pull request Feb 6, 2023
Closed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 6, 2023

Codecov Report

Base: 88.59% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (9e87cfe) compared to base (200557e).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #34963      +/-   ##
===========================================
- Coverage    88.59%   88.58%   -0.02%     
===========================================
  Files         2136     2136              
  Lines       396141   396143       +2     
===========================================
- Hits        350964   350926      -38     
- Misses       45177    45217      +40
Impacted Files Coverage Δ
src/sage/rings/qqbar.py 95.30% <100.00%> (+<0.01%) ⬆️
src/sage/homology/matrix_utils.py 83.48% <0.00%> (-4.59%) ⬇️
src/sage/categories/super_modules_with_basis.py 96.29% <0.00%> (-3.71%) ⬇️
...e/combinat/cluster_algebra_quiver/mutation_type.py 48.21% <0.00%> (-2.50%) ⬇️
src/sage/groups/additive_abelian/qmodnz.py 91.48% <0.00%> (-2.13%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.09% <0.00%> (-1.97%) ⬇️
...rc/sage/categories/super_lie_conformal_algebras.py 95.00% <0.00%> (-1.67%) ⬇️
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
...onformal_algebras/lie_conformal_algebra_element.py 95.52% <0.00%> (-1.50%) ⬇️
src/sage/crypto/stream.py 74.73% <0.00%> (-1.06%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 7, 2023 •
edited
Loading

Codecov Report

Base: 88.60% // Head: 88.58% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1692df2) compared to base (698001b).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #34963      +/-   ##
===========================================
- Coverage    88.60%   88.58%   -0.02%     
===========================================
  Files         2136     2136              
  Lines       396141   396141              
===========================================
- Hits        351009   350939      -70     
- Misses       45132    45202      +70
Impacted Files Coverage Δ
src/sage/groups/affine_gps/euclidean_group.py 88.88% <0.00%> (-11.12%) ⬇️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/groups/affine_gps/affine_group.py 96.62% <0.00%> (-2.25%) ⬇️
src/sage/doctest/forker.py 80.24% <0.00%> (-1.75%) ⬇️
src/sage/cpython/_py2_random.py 74.79% <0.00%> (-1.66%) ⬇️
src/sage/schemes/elliptic_curves/hom_frobenius.py 96.34% <0.00%> (-1.22%) ⬇️
src/sage/interfaces/ecm.py 92.48% <0.00%> (-1.16%) ⬇️
src/sage/modular/hecke/algebra.py 94.65% <0.00%> (-1.07%) ⬇️
src/sage/schemes/elliptic_curves/hom_velusqrt.py 94.48% <0.00%> (-0.79%) ⬇️
src/sage/groups/generic.py 88.34% <0.00%> (-0.68%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yyyyx4
Copy link
Copy Markdown
Member

yyyyx4 commented Feb 8, 2023

There are some code changes, but the current title only says "add doctest". Perhaps this should be changed.

@mezzarobba
Copy link
Copy Markdown
Member Author

mezzarobba commented Feb 8, 2023 via email

@vbraun vbraun merged commit 5a5f0a4 into sagemath:develop Feb 19, 2023
@mezzarobba mezzarobba deleted the test-20847 branch December 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yyyyx4 yyyyx4 yyyyx4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: algebra p: minor / 4 t: bug

Projects

None yet

Milestone

sage-10.0

Development

Successfully merging this pull request may close these issues.

PowerSeries_poly.reverse() should be more careful with conversions to pari

6 participants

@mezzarobba @codecov-commenter @yyyyx4 @vbraun @kwankyu @mkoeppe