src/sage/rings/polynomial: fix cython codegen

Feyorsh · Feyorsh · commit 0c96d61fb0f9 · 2024-03-21T19:49:50.000-05:00
function pointers to `cpdef`d functions don't work because of
dispatch
diff --git a/src/sage/rings/polynomial/hilbert.pyx b/src/sage/rings/polynomial/hilbert.pyx
@@ -106,7 +106,7 @@ cdef inline list interred(list L) noexcept:
     # that appears later in L.
     if not L:
         return []
-    L.sort(key=ETuple.unweighted_degree)
+    L.sort(key=ETuple._unweighted_degree)
     cdef size_t i
     cdef ETuple m
     cdef list result = [<ETuple> PyList_GET_ITEM(L, 0)]
diff --git a/src/sage/rings/polynomial/polydict.pxd b/src/sage/rings/polynomial/polydict.pxd
@@ -14,7 +14,9 @@ cdef class ETuple:
     cdef ETuple _new(self) noexcept
     cdef int get_exp(self, size_t i) noexcept
 
-    cpdef int unweighted_degree(self) except *
+    # can't use cpdef because function pointers
+    cdef int _unweighted_degree(self) except *
+    def int unweighted_degree(self) except *
     cpdef int weighted_degree(self, tuple w) except *
     cpdef int unweighted_quotient_degree(self, ETuple other) except *
     cpdef int weighted_quotient_degree(self, ETuple other, tuple w) except *
diff --git a/src/sage/rings/polynomial/polydict.pyx b/src/sage/rings/polynomial/polydict.pyx
@@ -1845,7 +1845,7 @@ cdef class ETuple:
 
     # additional methods
 
-    cpdef int unweighted_degree(self) except *:
+    cdef int _unweighted_degree(self) except *:
         r"""
         Return the sum of entries.
 
@@ -1863,6 +1863,21 @@ cdef class ETuple:
             degree += self._data[2 * i + 1]
         return degree
 
+    def int unweighted_degree(self) except *:
+        r"""
+        Return the sum of entries.
+
+        EXAMPLES::
+
+             sage: from sage.rings.polynomial.polydict import ETuple
+             sage: ETuple([1, 1, 0, 2, 0]).unweighted_degree()
+             4
+             sage: ETuple([-1, 1]).unweighted_degree()
+             0
+        """
+        return self._unweighted_degree()
+
+
     @cython.boundscheck(False)
     @cython.wraparound(False)
     cpdef int weighted_degree(self, tuple w) except *:
