Add Names for supported capabilities of interfaces#47
Merged
safchain merged 10 commits intosafchain:masterfrom Sep 16, 2023
gutjuri:bit-masks
Merged
Add Names for supported capabilities of interfaces#47safchain merged 10 commits intosafchain:masterfrom gutjuri:bit-masks
safchain merged 10 commits intosafchain:masterfrom
gutjuri:bit-masks
Conversation
|
Hi gutjuri, These bit flags are actually in go already, in the |
Contributor
Author
|
Thanks for this info. I wasn't aware of that, I guess this makes this PR redundant |
safchain
reviewed
Mar 8, 2022
Contributor
Author
|
@safchain Would you like to merge this PR into your project? Otherwise I'd close this PR. Or are more changes required? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, one can acquire a bitmask of supported modes of operation by using the
GetCmdMappedfunction:Unfortunately, there is no information on what the individual bits mean.
In this PR, I added the names of some supported capabilities (which I got from here: https://github.com/lyonel/lshw/blob/fdab06ac0b190ea0aa02cd468f904ed69ce0d9f1/src/core/network.cc#L113). This enables users of this library to seamlessly check, which capacities the interface in question supports.
closes #46