Fix converting zero-terminated string to Go string#40
Merged
safchain merged 1 commit intosafchain:masterfrom Oct 27, 2021
Merged
Fix converting zero-terminated string to Go string#40safchain merged 1 commit intosafchain:masterfrom
safchain merged 1 commit intosafchain:masterfrom
Conversation
8728c74 to
10a59c5
Compare
Contributor
Author
|
Added test cases for it. |
The version for bridge and tun devices is reported incorrectly. For example, DriverInfo.Version reports `2.3.0-22-generic` with a zero character after `2.3`. The `ethtool -i` command reports the version as `2.3`. So strip all characters starting from the zero character. Fixes: safchain#39 Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version for bridge and tun devices is reported incorrectly. For example, DriverInfo.Version reports
2.3.0-22-genericwith a zero character after2.3. Theethtool -icommand reports the version as2.3.So strip all characters starting from the zero character.
Fixes: #39