Skip to content

Improve Go compatibility#108

Merged
safchain merged 1 commit intosafchain:masterfrom
SuperQ:superq/go_version
Aug 5, 2025
Merged

Improve Go compatibility#108
safchain merged 1 commit intosafchain:masterfrom
SuperQ:superq/go_version

Conversation

@SuperQ
Copy link
Copy Markdown
Contributor

@SuperQ SuperQ commented Aug 3, 2025

The upstream Go support policy is to support the latest two major versions of Go. Update the go directive that specifies the minimum Go version required to support Go 1.23.x.

  • Pin GitHub actions for supply chain security.
  • Add matrix test for current Go versions.
  • Bump golangci-lint version.

@SuperQ SuperQ force-pushed the superq/go_version branch from 192c134 to 82a9316 Compare August 3, 2025 07:19
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not keeping the v4 & v5 which are pointing to the latest v4 & v5 version ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For supply chain security it's recommended.

@SuperQ SuperQ force-pushed the superq/go_version branch from 82a9316 to b903ea5 Compare August 5, 2025 16:59
The upstream Go support policy is to support the latest two major
versions of Go. Update the `go` directive that specifies the minimum
Go version required to support Go 1.23.x.
* Pin GitHub actions for supply chain security.
* Add matrix test for current Go versions.
* Bump golangci-lint version.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ force-pushed the superq/go_version branch from b903ea5 to 8b27294 Compare August 5, 2025 17:02
@SuperQ SuperQ requested a review from safchain August 5, 2025 17:02
@safchain safchain merged commit de57b3e into safchain:master Aug 5, 2025
3 checks passed
@SuperQ SuperQ deleted the superq/go_version branch August 5, 2025 19:16
@SuperQ
Copy link
Copy Markdown
Contributor Author

SuperQ commented Aug 6, 2025

Would you mind cutting v0.6.2 with this change?

@safchain
Copy link
Copy Markdown
Owner

safchain commented Aug 6, 2025

@SuperQ , thanks for the contribution. I just released a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants