fix: handle instance start errors in dynamic and blocking strategies#854
Merged
Conversation
|
Codecov Report❌ Patch coverage is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
When
InstanceStartreturns an error (e.g. container not found), both strategies now handle it properly instead of silently ignoring it.Problem
InstanceInfoWithError.Errorwas set whenInstanceStartfailed, but neither strategy checked it:sessionStateToRenderOptionsInstanceStateonly usedv.Instance, ignoringv.Error. The zero-valueInstanceInfo{}was rendered as an empty loading screen that refreshed forever.RequestReadySessiononly checkedsession.IsReady()and the top-level error fromRequestSession. Individual instance errors were never inspected, causing needless retries until timeout.Fix
internal/api/start_dynamic.go): Whenv.Erroris non-nil, render the instance with the requested name,unrecoverablestatus, and the provider error. This uses the existing error rendering support in all built-in themes ({{ if $instance.Error }}). The page continues to auto-refresh (200 OK), which is by design — the reverse proxy plugins use theX-Sablier-Statusheader for flow control, and the auto-refresh allows recovery if the user fixes the issue (e.g. creates the missing container).pkg/sablier/session_request.go): Checksession.InstanceErrors()after eachRequestSessioncall and return early with an error (500) instead of retrying until timeout.pkg/sablier/session.go): AddSessionState.InstanceErrors()method that collects and joins individual instance errors.Before / After
http://localhost:10000/api/strategies/dynamic?names=foobar&session_duration=5m&theme=hacker-terminalBefore
After
Fixes #853