Skip to content

fix(webhooks): avoid gorouting leaks#925

Merged
acouvreur merged 1 commit into
mainfrom
add-waitgroup-webhooks
May 17, 2026
Merged

fix(webhooks): avoid gorouting leaks#925
acouvreur merged 1 commit into
mainfrom
add-waitgroup-webhooks

Conversation

@acouvreur

Copy link
Copy Markdown
Member

Wait for all webhooks goroutine to end before returning.

Wait for all webhooks goroutine to end before returning.
@github-actions

Copy link
Copy Markdown

Test Results

✅ All tests passed! | 448 tests in 83.671s

View HTML Test Report

@sonarqubecloud

Copy link
Copy Markdown

@acouvreur acouvreur merged commit c02d98b into main May 17, 2026
8 checks passed
@acouvreur acouvreur deleted the add-waitgroup-webhooks branch May 17, 2026 13:19
@github-actions

Copy link
Copy Markdown
┌───────────────────────────────────────────────────────────────────────────────────────┐
│ Diff between sablier and sablier                                                      │
├─────────┬─────────────────────────────────────────────┬──────────┬──────────┬─────────┤
│ PERCENT │ NAME                                        │ OLD SIZE │ NEW SIZE │ DIFF    │
├─────────┼─────────────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +39.47% │ github.com/sablierapp/sablier               │ 325 kB   │ 454 kB   │ +128 kB │
│ +77.83% │ errors                                      │ 11 kB    │ 19 kB    │ +8.3 kB │
│ +1.69%  │ time                                        │ 157 kB   │ 160 kB   │ +2.7 kB │
│ +0.06%  │ runtime                                     │ 3.2 MB   │ 3.2 MB   │ +1.8 kB │
│ +46.44% │ github.com/docker/go-units                  │ 3.3 kB   │ 4.8 kB   │ +1.5 kB │
│ +0.52%  │ go.yaml.in/yaml/v2                          │ 275 kB   │ 277 kB   │ +1.4 kB │
│ +0.29%  │ github.com/diskfs/go-diskfs                 │ 329 kB   │ 330 kB   │ +940 B  │
│ +0.63%  │ github.com/spf13/viper                      │ 73 kB    │ 74 kB    │ +461 B  │
│ +0.13%  │ text/template                               │ 292 kB   │ 292 kB   │ +389 B  │
│ +0.40%  │ go.opentelemetry.io/auto/sdk                │ 89 kB    │ 89 kB    │ +357 B  │
│ +0.29%  │ vendor/golang.org/x/net/http2/hpack         │ 35 kB    │ 35 kB    │ +102 B  │
│ +0.11%  │ golang.org/x/crypto                         │ 91 kB    │ 91 kB    │ +101 B  │
│ +0.02%  │ k8s.io/klog/v2                              │ 124 kB   │ 124 kB   │ +31 B   │
│ +0.00%  │ k8s.io/client-go                            │ 14 MB    │ 14 MB    │ +27 B   │
│ +0.31%  │ internal/cpu                                │ 6.1 kB   │ 6.1 kB   │ +19 B   │
│ +0.00%  │ k8s.io/api                                  │ 17 MB    │ 17 MB    │ +8 B    │
│ +0.00%  │ k8s.io/apimachinery                         │ 1.8 MB   │ 1.8 MB   │ +6 B    │
│ +0.00%  │ log                                         │ 126 kB   │ 126 kB   │ +6 B    │
│ +0.00%  │ github.com/moby/moby/api                    │ 149 kB   │ 149 kB   │ +6 B    │
│ +0.00%  │ github.com/moby/moby/client                 │ 434 kB   │ 434 kB   │ +4 B    │
│ +0.00%  │ encoding/json                               │ 172 kB   │ 172 kB   │ +4 B    │
│ +0.00%  │ github.com/gin-gonic/gin                    │ 336 kB   │ 336 kB   │ +4 B    │
│ +0.00%  │ html                                        │ 136 kB   │ 136 kB   │ +2 B    │
│ -0.01%  │ github.com/pmezard/go-difflib               │ 17 kB    │ 17 kB    │ -1 B    │
│ -0.01%  │ sort                                        │ 29 kB    │ 29 kB    │ -2 B    │
│ -0.00%  │ github.com/spf13/pflag                      │ 302 kB   │ 302 kB   │ -2 B    │
│ -0.00%  │ github.com/davecgh/go-spew                  │ 54 kB    │ 54 kB    │ -2 B    │
│ -0.00%  │ google.golang.org/protobuf                  │ 1.7 MB   │ 1.7 MB   │ -4 B    │
│ -0.01%  │ github.com/prometheus/common                │ 68 kB    │ 68 kB    │ -4 B    │
│ -0.00%  │ github.com/quic-go/quic-go                  │ 1.3 MB   │ 1.3 MB   │ -4 B    │
│ -0.00%  │ sigs.k8s.io/json                            │ 173 kB   │ 173 kB   │ -4 B    │
│ -0.00%  │ os                                          │ 210 kB   │ 210 kB   │ -5 B    │
│ -0.01%  │ unique                                      │ 34 kB    │ 34 kB    │ -5 B    │
│ -0.05%  │ embed                                       │ 12 kB    │ 12 kB    │ -6 B    │
│ -0.00%  │ golang.org/x/text                           │ 162 kB   │ 162 kB   │ -7 B    │
│ -0.00%  │ reflect                                     │ 340 kB   │ 340 kB   │ -8 B    │
│ -0.00%  │ go.mongodb.org/mongo-driver/v2              │ 672 kB   │ 672 kB   │ -9 B    │
│ -0.00%  │ sigs.k8s.io/structured-merge-diff/v6        │ 275 kB   │ 275 kB   │ -9 B    │
│ -0.06%  │ github.com/spf13/afero                      │ 21 kB    │ 21 kB    │ -12 B   │
│ -0.00%  │ github.com/json-iterator/go                 │ 462 kB   │ 462 kB   │ -15 B   │
│ -0.30%  │ vendor/golang.org/x/sys/cpu                 │ 6.4 kB   │ 6.4 kB   │ -19 B   │
│ -0.01%  │ go.yaml.in/yaml/v3                          │ 312 kB   │ 312 kB   │ -22 B   │
│ -0.00%  │ net                                         │ 1.7 MB   │ 1.7 MB   │ -27 B   │
│ -0.14%  │ k8s.io/utils                                │ 32 kB    │ 32 kB    │ -45 B   │
│ -0.00%  │ crypto                                      │ 1.9 MB   │ 1.9 MB   │ -51 B   │
│ -0.14%  │ vendor/golang.org/x/crypto/chacha20poly1305 │ 71 kB    │ 71 kB    │ -101 B  │
│ -0.01%  │ golang.org/x/net                            │ 789 kB   │ 789 kB   │ -118 B  │
│ -0.09%  │ go.opentelemetry.io/otel                    │ 407 kB   │ 407 kB   │ -363 B  │
│ -0.46%  │ gopkg.in/yaml.v3                            │ 305 kB   │ 304 kB   │ -1.4 kB │
│ -0.34%  │ <autogenerated>                             │ 948 kB   │ 945 kB   │ -3.2 kB │
├─────────┼─────────────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +19.30% │ .rodata                                     │ 2.1 MB   │ 2.5 MB   │ +411 kB │
│ +0.18%  │ .data                                       │ 196 kB   │ 196 kB   │ +352 B  │
│ +0.01%  │ .noptrdata                                  │ 451 kB   │ 451 kB   │ +32 B   │
├─────────┼─────────────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +0.95%  │ sablier                                     │ 59 MB    │ 59 MB    │ +561 kB │
│         │ sablier                                     │          │          │         │
└─────────┴─────────────────────────────────────────────┴──────────┴──────────┴─────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant