Skip to content

refactor: watch groups through events#910

Merged
acouvreur merged 5 commits into
mainfrom
refactor-group-watching
May 14, 2026
Merged

refactor: watch groups through events#910
acouvreur merged 5 commits into
mainfrom
refactor-group-watching

Conversation

@acouvreur

@acouvreur acouvreur commented May 14, 2026

Copy link
Copy Markdown
Member

And do a reconciliation loop every 30s.

Previously, we aggressively fetched all groups every two seconds.

@acouvreur
refactor: watch groups through events
f1d611c 
And do a reconciliation loop every 30s.

Previously, we aggressively fetched all groups every two seconds.
@github-actions github-actions Bot added the provider Issue related to a provider label May 14, 2026
@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown 
┌────────────────────────────────────────────────────────────────────────────────┐
│ Diff between sablier and sablier                                               │
├─────────┬──────────────────────────────────────┬──────────┬──────────┬─────────┤
│ PERCENT │ NAME                                 │ OLD SIZE │ NEW SIZE │ DIFF    │
├─────────┼──────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +28.52% │ github.com/sablierapp/sablier        │ 325 kB   │ 418 kB   │ +93 kB  │
│ +0.03%  │ k8s.io/client-go                     │ 14 MB    │ 14 MB    │ +3.9 kB │
│ +1.69%  │ time                                 │ 157 kB   │ 160 kB   │ +2.7 kB │
│ +0.22%  │ <autogenerated>                      │ 948 kB   │ 950 kB   │ +2.0 kB │
│ +0.58%  │ go.yaml.in/yaml/v3                   │ 312 kB   │ 314 kB   │ +1.8 kB │
│ +46.44% │ github.com/docker/go-units           │ 3.3 kB   │ 4.8 kB   │ +1.5 kB │
│ +0.02%  │ runtime                              │ 3.2 MB   │ 3.2 MB   │ +508 B  │
│ +0.29%  │ vendor/golang.org/x/net/http2/hpack  │ 35 kB    │ 35 kB    │ +102 B  │
│ +0.03%  │ sigs.k8s.io/json                     │ 173 kB   │ 173 kB   │ +54 B   │
│ +0.11%  │ vendor/golang.org/x/net/idna         │ 22 kB    │ 22 kB    │ +25 B   │
│ +0.31%  │ internal/cpu                         │ 6.1 kB   │ 6.1 kB   │ +19 B   │
│ +0.00%  │ k8s.io/kube-openapi                  │ 466 kB   │ 466 kB   │ +17 B   │
│ +0.00%  │ go.opentelemetry.io/otel             │ 407 kB   │ 407 kB   │ +17 B   │
│ +0.01%  │ log                                  │ 126 kB   │ 126 kB   │ +16 B   │
│ +0.00%  │ k8s.io/apimachinery                  │ 1.8 MB   │ 1.8 MB   │ +9 B    │
│ +0.00%  │ github.com/moby/moby/api             │ 149 kB   │ 149 kB   │ +6 B    │
│ +0.00%  │ github.com/gin-gonic/gin             │ 336 kB   │ 336 kB   │ +4 B    │
│ +0.00%  │ k8s.io/klog/v2                       │ 124 kB   │ 124 kB   │ +2 B    │
│ +0.00%  │ text/template                        │ 292 kB   │ 292 kB   │ +1 B    │
│ -0.00%  │ github.com/spf13/pflag               │ 302 kB   │ 302 kB   │ -2 B    │
│ -0.01%  │ sort                                 │ 29 kB    │ 29 kB    │ -2 B    │
│ -0.00%  │ go.mongodb.org/mongo-driver/v2       │ 672 kB   │ 672 kB   │ -2 B    │
│ -0.00%  │ os                                   │ 210 kB   │ 210 kB   │ -2 B    │
│ -0.00%  │ html                                 │ 136 kB   │ 136 kB   │ -2 B    │
│ -0.00%  │ google.golang.org/protobuf           │ 1.7 MB   │ 1.7 MB   │ -4 B    │
│ -0.01%  │ unique                               │ 34 kB    │ 34 kB    │ -4 B    │
│ -0.00%  │ reflect                              │ 340 kB   │ 340 kB   │ -4 B    │
│ -0.01%  │ github.com/prometheus/common         │ 68 kB    │ 68 kB    │ -4 B    │
│ -0.00%  │ github.com/google/gnostic-models     │ 1.6 MB   │ 1.6 MB   │ -5 B    │
│ -0.05%  │ embed                                │ 12 kB    │ 12 kB    │ -6 B    │
│ -0.00%  │ k8s.io/api                           │ 17 MB    │ 17 MB    │ -6 B    │
│ -0.00%  │ sigs.k8s.io/structured-merge-diff/v6 │ 275 kB   │ 275 kB   │ -6 B    │
│ -0.01%  │ golang.org/x/text                    │ 162 kB   │ 162 kB   │ -9 B    │
│ -0.06%  │ github.com/spf13/afero               │ 21 kB    │ 21 kB    │ -12 B   │
│ -0.00%  │ net                                  │ 1.7 MB   │ 1.7 MB   │ -12 B   │
│ -0.05%  │ k8s.io/utils                         │ 32 kB    │ 32 kB    │ -17 B   │
│ -0.30%  │ vendor/golang.org/x/sys/cpu          │ 6.4 kB   │ 6.4 kB   │ -19 B   │
│ -0.03%  │ go.opentelemetry.io/auto/sdk         │ 89 kB    │ 89 kB    │ -23 B   │
│ -0.01%  │ go.yaml.in/yaml/v2                   │ 275 kB   │ 275 kB   │ -32 B   │
│ -0.00%  │ crypto                               │ 1.9 MB   │ 1.9 MB   │ -44 B   │
│ -0.04%  │ encoding/json                        │ 172 kB   │ 172 kB   │ -71 B   │
│ -0.02%  │ golang.org/x/net                     │ 789 kB   │ 789 kB   │ -129 B  │
│ -0.02%  │ github.com/quic-go/quic-go           │ 1.3 MB   │ 1.3 MB   │ -261 B  │
│ -0.58%  │ gopkg.in/yaml.v3                     │ 305 kB   │ 304 kB   │ -1.8 kB │
├─────────┼──────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +19.22% │ .rodata                              │ 2.1 MB   │ 2.5 MB   │ +410 kB │
│ +0.01%  │ .noptrdata                           │ 451 kB   │ 451 kB   │ +32 B   │
├─────────┼──────────────────────────────────────┼──────────┼──────────┼─────────┤
│ +0.88%  │ sablier                              │ 59 MB    │ 59 MB    │ +516 kB │
│         │ sablier                              │          │          │         │
└─────────┴──────────────────────────────────────┴──────────┴──────────┴─────────┘

@github-actions

github-actions Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

✅ All tests passed! | 401 tests in 137.246s

⚠️ 1 test(s) were flaky (failed then passed on rerun)

  • github.com/sablierapp/sablier/pkg/provider/dockerswarm/TestDockerSwarmProvider_InstanceEvents_Created
    View HTML Test Report

@acouvreur acouvreur marked this pull request as ready for review May 14, 2026 21:03
@sonarqubecloud

sonarqubecloud Bot commented May 14, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@acouvreur acouvreur merged commit 44b57a9 into main May 14, 2026
7 of 8 checks passed
@acouvreur acouvreur deleted the refactor-group-watching branch May 14, 2026 22:17
@sablier-bot sablier-bot Bot mentioned this pull request May 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

provider Issue related to a provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@acouvreur