Yes, it's better to split the flag, i would say require-sablier-enabled for the first one, for the second one require-sablier-enabled-on-expiration maybe ? It's hard to write a clear flag that's not too long

Yes, it's better to split the flag, i would say require-sablier-enabled for the first one, for the second one require-sablier-enabled-on-expiration maybe ? It's hard to write a clear flag that's not too long

I think those express a better intent:

provider.reject-unlabeled-requests

Purpose: reject incoming requests when the target instance is not sablier.enable=true.

EDIT: It's worth noting that provider.reject-unlabeled-requests is only intended for the API using the names query param, and not the group. Because by definition, all groups only retrieve enabled instances.

provider.verify-enabled-on-expiration

Purpose: on expiration, re-check the instance label and only stop if sablier.enable=true.

I've made Claude Sonnet analyze the PR and give some suggestion, and I think I agree with those suggestions, the intent is very clear and represent properly the new features

@louisdtt I'm sorry I've introduced new command flags recently, you have to rebase again. I will wait for your rebase before merging any further PRs

@louisdtt I'm sorry I've introduced new command flags recently, you have to rebase again. I will wait for your rebase before merging any further PRs

Ok I lied, I've just merged #907

Let me know if you need help to resolve the merge conflict

Don't worry, l'll do it in a few hours

All tests ok, the build error is just sonar

Maybe one last thing, @louisdtt could you create 2 working examples under examples/ so that it is easy to demonstrate and test in an end to end scenario ? After that, we can merge if testing is successful

Ok, let me try the examples and we're good to go

Ok, I've tried both example. Both works, but I had a few issues with the verify example:

make test
docker compose up -d
[+] Running 3/3
 ✔ Network verify-enabled-on-expiration_default      Created                                                                                                                                                                     0.0s
 ✔ Container sablier-verify-expiration-unlabeled     Started                                                                                                                                                                     0.5s
 ✔ Container verify-enabled-on-expiration-sablier-1  Started                                                                                                                                                                     0.4s
curl: (56) Recv failure: Connection reset by peer
==> Stopping unlabeled container before requesting a session
docker compose stop unlabeled
[+] Stopping 1/1
 ✔ Container sablier-verify-expiration-unlabeled  Stopped                                                                                                                                                                        0.1s
==> Requesting unlabeled container by names
curl -fsS 'http://localhost:10000/api/strategies/blocking?names=sablier-verify-expiration-unlabeled&session_duration=3s&timeout=10s' > "/tmp/sablier-verify-enabled-on-expiration-response.json"
curl: (22) The requested URL returned error: 500
make: *** [test] Error 22

I will merge it now as this is just an example.