I just set up Sablier and I wanted to give some feedback about issues I had with the configuration:
- The word "strategy" is used for
stop vs pause and also for dynamic vs blocking, which is a bit confusing.
strategy.dynamic.show-details-by-default is true in the sample config but false in the docs, which could be wrongly interpreted as false being the default.
- I found out about
provider.auto-stop-on-startup from some GitHub issue, it is completely absent from the docs.
- Virtually every other project uses a prefix for environment variables, so it's quite surprising that Sablier doesn't. In other words,
STRATEGY_DYNAMIC_CUSTOM_THEMES_PATH should be SABLIER_STRATEGY_DYNAMIC_CUSTOM_THEMES_PATH.
- The README just says "Configuration sources are evaluated in the order listed above". Luckily the docs add the all-important "with later methods overriding earlier ones".
I just set up Sablier and I wanted to give some feedback about issues I had with the configuration:
stopvspauseand also fordynamicvsblocking, which is a bit confusing.strategy.dynamic.show-details-by-defaultistruein the sample config butfalsein the docs, which could be wrongly interpreted asfalsebeing the default.provider.auto-stop-on-startupfrom some GitHub issue, it is completely absent from the docs.STRATEGY_DYNAMIC_CUSTOM_THEMES_PATHshould beSABLIER_STRATEGY_DYNAMIC_CUSTOM_THEMES_PATH.