fix: bump go 1.25#723
Merged
Merged
Conversation
also bump deps and fix golangci lint
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to bump the Go version to 1.25 and updates various dependencies. However, Go 1.25 does not exist yet - as of my knowledge cutoff in January 2025, the latest stable Go versions are 1.23.x and 1.24.x. The PR also includes several code quality improvements to address golangci-lint issues.
Key changes (aside from the invalid version bump):
- Improved error handling across test files and source code by checking return values from
Put(),Flush(),Write(), andSetenv()calls - Refactored Docker Swarm API usage to use
swarm.ServiceUpdateOptionsandservice.Versioninstead of deprecated types - Fixed import ordering to follow Go conventions (stdlib, blank line, external packages)
- Improved logging context usage (using
context.TODO()instead ofnil)
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Invalid: Updates Go version to non-existent 1.25.4; updates dependencies to newer versions |
| Dockerfile | Invalid: Updates base image to non-existent golang:1.25 |
| pkg/tinykv/tinykv_test.go | Adds error checking for Put() and Setenv() calls using require.NoError and assert.NoError |
| pkg/tinykv/tinykv.go | Adds error handling in UnmarshalJSON, simplifies loop logic, explicitly ignores return value with _ |
| pkg/provider/dockerswarm/*.go | Updates Docker API types and field references; adds error handling for provider initialization |
| pkg/provider/docker/*.go | Fixes import ordering; adds error handling for provider initialization; refactors if-else to switch |
| internal/server/server.go | Fixes import ordering; simplifies variable declaration |
| internal/server/logging.go | Fixes import ordering; uses context.TODO() instead of nil for logger |
| internal/api/start_dynamic.go | Fixes import ordering; adds error handling for Flush() and Write() operations |
| go.sum | Updates dependency checksums to match go.mod changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also bump deps and fix golangci lint