Skip to content

Always scales back up to 1 replica on Kubernetes #258

Description

@dimber-cais

Describe the issue
When Sablier scales up a previously scaled down deployment, it always scales it to 1 pod, and does not return the deployment back to the value of replicas specified in the original YAML.

Context

  • Sablier version: All
  • Provider: Kubernetes
  • Reverse proxy: N/A
  • Sablier running inside a container? Yes

Expected behavior
It should be possible to scale back up to multiple replicas when scaling back up from zero. This could either be by capturing the original spec.replicas for the deployment and using that, or introducing a new sablier.replicas label.

Additional context
This would allow Sablier to be used in scenarios where workloads should both scale to zero when not in use and scale to a highly available multi-instance deployment when in use.

I could try to contribute this as a PR if you are open for this......

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions