Merged
Conversation
fviard
reviewed
Nov 4, 2022
Contributor
|
Thank you very much for your PR. |
Contributor
|
Merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you only specify a bucket:
Then the request will look like:
In the case of
AWSthis isn't a huge deal:However,
cephinterprets this as a delete bucket request not an abortmp request. If there are any regular objects in the bucket you get:But if all you have are incomplete multiparts then
cephactually deletes the bucket.I intend to open a bug with ceph as well, but since
s3cmdisn't following the S3 API spec I still think this PR is useful:https://docs.aws.amazon.com/AmazonS3/latest/API/API_AbortMultipartUpload.html
Let me know if there's a better approach / I should write a test for this.