Take into account the AWS_STS_REGIONAL_ENDPOINTS#1227
Merged
fviard merged 1 commit intos3tools:masterfrom Jan 21, 2022
Merged
Conversation
This was referenced Jan 14, 2022
|
Hi, Thanks ! |
fviard
reviewed
Jan 15, 2022
fviard
reviewed
Jan 15, 2022
Contributor
|
It's all good now, thank you. Could you "squash" your changes into a single commit before I merge please? |
This fixes the issue where the sts endpoint sts.amazonaws.com is not accessible. Take into account the environment varialbe AWS_STS_REGIONAL_ENDPOINTS If the variable is provided check for AWS_REGION env var to decide region. IF AWS_REGION is not provided use the same region as the bucket. (bucket_location parameter)
4eb52f5 to
dbee02a
Compare
Author
|
Should be all good ! |
Contributor
|
Merged, thank you! |
|
Thank you @fviard. Can we have a release with this fix included please ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the sts endpoint sts.amazonaws.com is not
accessible.
Take into account the environment varialbe AWS_STS_REGIONAL_ENDPOINTS
If the AWS_STS_REGIONAL_ENDPOINTS variable is provided check for AWS_REGION env var to decide
region.
If AWS_REGION is not provided use the same region as the bucket.
(bucket_location parameter)