Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

ci: remove protoc installation step#191

Merged
quettabit merged 1 commit intomainfrom
qb/rm-protoc
Jan 18, 2026
Merged

ci: remove protoc installation step#191
quettabit merged 1 commit intomainfrom
qb/rm-protoc

Conversation

@quettabit
Copy link
Member

No description provided.

@quettabit
Copy link
Member Author

@greptileai review this draft

@greptile-apps
Copy link

greptile-apps bot commented Jan 17, 2026

Greptile Summary

Removes the protoc installation step from CI and release workflows. This is a valid cleanup since the repository has no .proto files or build.rs file - the Protocol Buffers types come pre-compiled from the s2-sdk and s2-api crates on crates.io.

  • Removed arduino/setup-protoc@v3 action from both test and lint jobs in ci.yml
  • Removed arduino/setup-protoc@v3 action from build_binaries job in release.yml
  • No issues found - this should reduce CI time and simplify the build pipeline

Confidence Score: 5/5

  • This PR is safe to merge - it removes an unnecessary build dependency that was never used.
  • The protoc compiler was installed but never invoked. There are no .proto files or build.rs scripts in this repository. The prost dependency comes pre-compiled from s2-sdk/s2-api crates, so protoc is not needed at build time.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Removed unnecessary protoc installation from test and lint jobs; no .proto files exist in this repo.
.github/workflows/release.yml Removed unnecessary protoc installation from build_binaries job; protobuf code comes pre-compiled from s2-sdk crate.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CI as CI Workflow
    participant Cargo as Cargo Build
    participant Crates as crates.io

    Dev->>CI: Push/PR
    CI->>CI: Checkout code
    CI->>CI: Install Rust toolchain
    Note over CI: protoc step removed
    CI->>Cargo: cargo build/test
    Cargo->>Crates: Fetch s2-sdk (pre-compiled)
    Crates-->>Cargo: Return crate with prost types
    Cargo-->>CI: Build successful
    CI-->>Dev: CI passed
Loading

@quettabit quettabit changed the title [WIP] ci: remove protoc installation step Jan 18, 2026
@quettabit quettabit marked this pull request as ready for review January 18, 2026 00:09
@quettabit quettabit requested a review from a team as a code owner January 18, 2026 00:09
@quettabit quettabit merged commit 38f562c into main Jan 18, 2026
4 checks passed
@quettabit quettabit deleted the qb/rm-protoc branch January 18, 2026 00:10
@greptile-apps greptile-apps bot mentioned this pull request Jan 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant