This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Merged
Conversation
Greptile SummaryAdds deduplication logic to reduce console noise when multiple append acknowledgments share the same
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Input as Record Stream
participant Append as ops::append
participant Producer as S2 Producer
participant Main as main.rs Loop
participant Console as stderr Output
Input->>Append: Records
Append->>Producer: Submit records with permits
Producer-->>Append: IndexedAppendAck(s)
Append-->>Main: Ack stream
loop Process acks
Main->>Main: Receive ack
Main->>Main: Check if batch.end.seq_num != last_printed
alt New batch end
Main->>Main: Update last_printed_batch_end
Main->>Console: Print ✓ [APPENDED] message
else Duplicate batch end
Main->>Main: Skip printing (deduplication)
end
end
|
| .green() | ||
| .bold() | ||
| ); | ||
| if last_printed_batch_end.is_none_or(|end| end != ack.batch.end.seq_num) { |
There was a problem hiding this comment.
logic: only checks if the current batch end differs from the last printed one, not if it's been printed before - if acks arrive out of order (e.g. 100, 200, 100), the second occurrence of 100 would print again
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/main.rs
Line: 356:356
Comment:
**logic:** only checks if the current batch end differs from the **last** printed one, not if it's been printed before - if acks arrive out of order (e.g. 100, 200, 100), the second occurrence of 100 would print again
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now there is an ack for every record