Use __ as delimiter for embedded statuses #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaves ":" free for other uses, converts to use __getattr__ instead of __getattribute__ to avoid checking on every attribute access.
Codecov Report
@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 81.06% 81.03% -0.03%
==========================================
Files 155 155
Lines 15071 15079 +8
Branches 3250 3250
==========================================
+ Hits 12217 12219 +2
- Misses 2610 2615 +5
- Partials 244 245 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Owner
Author
|
Ping @starkillerOG – looks like the previous implementation used wrong dunder method for accessing the custom attributes, this should fix the issues you had when you tried to use |
Contributor
|
Thanks for looking into this, I will test this as soon as possible |
Contributor
|
@rytilahti I just tested it and it works as advertised, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaves ":" free for other uses,
converts to use
__getattr__instead of__getattribute__to avoid checking on every attribute access.