Implement device factory #1556
Merged
Implement device factory #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it simple for downstream users to construct device instances for all supported devices given only the host and its token. All device subclasses register themselves automatically to the factory. The create(host, token, model=None) class method is the main entry point to use this.
This was referenced Oct 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
- Coverage 81.05% 81.05% -0.01%
==========================================
Files 153 154 +1
Lines 15024 15073 +49
Branches 3680 3697 +17
==========================================
+ Hits 12178 12217 +39
- Misses 2599 2609 +10
Partials 247 247
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it simple for downstream users to construct device instances for all supported devices given only the host and its token.
All device subclasses register themselves automatically to the factory. The create(host, token, model=None) class method is the main entry point to use this.
Supersedes #1328
Fixes #1117