Fix artifact download endpoint to match correct server route#435
Merged
Fix artifact download endpoint to match correct server route#435
Conversation
Previously called /mint/api/artifact_downloads/:key?task_id=... which didn't match any route. The correct endpoint is /mint/api/artifact_download with key passed as a query param.
dan-manges
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rwx artifacts download <task-id> <key>was always returning 404. The CLI was callingGET /mint/api/artifact_downloads/<key>?task_id=<id>, which doesn't match any route in the server. Rails was returning a routing-level 404 before the request ever reached the controller.Solution
GetArtifactDownloadRequestto callGET /mint/api/artifact_download?task_id=<id>&key=<key>, which matches theartifact_download_by_keyroute (routes.rb line 310)keyquery paramFurther confirmation needed
rwx artifacts downloadworks end-to-end against a real task with artifacts