Skip to content

Add rwx vaults oidc-tokens create command#430

Merged
robinaugh merged 1 commit intomainfrom
jason/rwx-138-oidc-cli-command
Mar 17, 2026
Merged

Add rwx vaults oidc-tokens create command#430
robinaugh merged 1 commit intomainfrom
jason/rwx-138-oidc-cli-command

Conversation

@robinaugh
Copy link
Contributor

@robinaugh robinaugh commented Mar 16, 2026

Summary

  • Adds rwx vaults oidc-tokens create command with --vault (required), --name, --audience, and --provider flags
  • Provider resolution is fully delegated to the API — the CLI passes --provider through and lets the server handle defaults and validation
  • Client-side validation only ensures --name and --audience are present when --provider is not given
  • Handles both {"error": "..."} and {"errors": [...]} response formats from the API
  • Supports --output json for structured output

Test plan

  • 7 unit tests covering: explicit name+audience, provider passthrough, provider with overrides, missing name/audience validation, API error propagation, JSON output
  • End-to-end verification against the API

@robinaugh robinaugh self-assigned this Mar 16, 2026
@robinaugh robinaugh force-pushed the jason/rwx-138-oidc-cli-command branch 2 times, most recently from 5b68d49 to bebc1e3 Compare March 16, 2026 23:16
@robinaugh robinaugh changed the title Add rwx vaults oidc-token create command Add rwx vaults oidc-tokens create command Mar 16, 2026
Implements the CLI command for creating OIDC tokens on vaults. Provider
resolution is delegated to the API; the CLI only validates that --name
and --audience are present when --provider is not given.
@robinaugh robinaugh force-pushed the jason/rwx-138-oidc-cli-command branch from bebc1e3 to c088acb Compare March 16, 2026 23:18
@robinaugh robinaugh marked this pull request as ready for review March 17, 2026 12:51
@robinaugh robinaugh merged commit 0d87495 into main Mar 17, 2026
1 check passed
@robinaugh robinaugh deleted the jason/rwx-138-oidc-cli-command branch March 17, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants