Conversation
a8437f1 to
f1bd4c9
Compare
7 tasks
…e it Extract the git branch/repo → latest run ID resolution into a shared service method so it can be reused by other commands. Refactor results.go to use it instead of inlining the same logic.
Support resolving tasks by key (e.g., ci.checks.lint) instead of task ID for rwx logs, rwx artifacts list, and rwx artifacts download. When --task is used, the run ID can be provided as a positional arg or inferred from git context via the shared ResolveRunIDFromGitContext helper. Also migrates existing log/artifact API methods to use the new non-nested routes (/mint/api/log_download, /mint/api/artifact_downloads) for consistency with the task-key variants. Handles ambiguous keys (422) by displaying matching fully-qualified keys and not-found errors (404) with descriptive messages.
When --task is used and the server returns a not-found error, the CLI now suggests running `rwx results --all` (or `rwx results <run-id> --all` when the run ID was provided explicitly) to discover available task keys.
…_key Preserve ErrNotFound sentinel through the service and command layers so telemetry classifies task-key not-found errors as "not_found" instead of "unknown". Add ErrAmbiguousTaskKey sentinel and wire it through AmbiguousTaskKeyError so ambiguous key errors are classified as "ambiguous_task_key".
f1bd4c9 to
c39e031
Compare
Instead of constructing the ambiguous task key message client-side from matching_keys, display the message returned by the server's 422 response directly. Remove the `rwx results --all` suggestion from task key error handling.
c39e031 to
b7cfdf6
Compare
TAGraves
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--task <key>flag torwx logs,rwx artifacts list, andrwx artifacts downloadthat resolves tasks by key (e.g.,ci.checks.lint) instead of requiring a task ID--taskis used, run ID can be provided as a positional arg or inferred from git context (same logic asrwx results)/mint/api/log_download,/mint/api/artifact_downloads) withrun_id+task_keyquery paramsBlocked by server-side PR: https://github.com/rwx-cloud/cloud/pull/7083
Test plan
rwx logs <taskId>still works (backward compat)rwx logs --task ci.checks.lintinfers run ID from git and downloads logsrwx logs <run-id> --task lintwith explicit run IDrwx artifacts list --task <key>andrwx artifacts list <run-id> --task <key>rwx artifacts download --task <key> <artifact-key>and with explicit run-idrwx artifacts download --task <key> --all--taskis used without git context and no run-id provided