Fix sandbox exec telemetry events never being sent#419
Merged
Conversation
The sandbox exec command called os.Exit(result.ExitCode) directly, which bypassed main()'s telemetry flush. This meant sandbox.exec (and sandbox.start for lazy-started sandboxes) events were recorded in memory but never sent to the server. Replace the os.Exit call with an ExitCodeError return so that main() can flush telemetry before exiting with the correct code.
jmsanders
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rwx sandbox execcalledos.Exit(result.ExitCode)directly inside its CobraRunE, which bypassedmain()'stelem.Flush()call. All telemetry events (sandbox.exec,sandbox.startfor lazy-starts,ssh.command,sandbox.sync_pull, etc.) were recorded in memory but never sent.ExitCodeErrortype so commands can signal a non-zero exit code via a normal error return, allowingmain()to flush telemetry before exiting.sandbox.exectelemetry is recorded even with non-zero exit codes.Test plan
TestTelemetry_SandboxExecNonZeroExitCodeverifies events are recorded for failed commandsrwx sandbox exec -- pwdand verify telemetry events appear server-side