Show spinner when waiting for sandbox lock#417
Merged
Conversation
When another sandbox operation or exec holds a lock, the CLI now shows a spinner instead of blocking silently. The file-based storage lock uses a try-then-block pattern so the spinner only appears when contended. The SSH directive lock uses a 500ms delay before showing to avoid flashing on uncontested acquires. Both are suppressed in JSON output mode.
kylekthompson
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output jsonmodeTest plan
TestService_LockWaitOutput)rwx sandbox execcommands and confirm spinner appears on the second