Thread patch sentinel error through run service#415
Merged
Conversation
eddb8e8 to
1583761
Compare
GeneratePatchFile now returns (PatchFile, error) instead of silently swallowing failures. In the run service, patch generation errors populate errorMessage and log a warning to stderr, matching the existing pattern for git-not-installed and not-in-repo scenarios. The run proceeds without a patch rather than aborting.
1583761 to
a04278f
Compare
3 tasks
jmsanders
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratePatchFilenow returns(PatchFile, error)instead of silently swallowing failuresErrPatchviaWrapSentinel, soclassifyErrorcategorizes them as"patch_failed"— consistent with the sandbox serviceMockGeneratePatchFileErrorFrom PR #408 review.
Test plan
TestGeneratePatchFiletests pass (error cases now assertrequire.Error, success cases assertrequire.NoError)TestService_InitiatingRunPatchtests passgo test ./internal/... ./cmd/...)