Show untracked file warning when there are no tracked changes#411
Merged
Show untracked file warning when there are no tracked changes#411
Conversation
When only untracked files exist (no staged or unstaged changes to tracked files), the untracked file warning was silently dropped. GeneratePatchFile discarded the metadata when the diff was empty, and the warning was gated behind patchFile.Written.
dan-manges
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeneratePatchFilereturned an emptyPatchFile{}, discarding the untracked files metadataservice_run.gowas gated behindpatchFile.Written, so it was never shown in this caseGeneratePatchFilepreserves untracked metadata even when the diff is empty, and the warning displays independently of whether a patch was writtenTest plan
GeneratePatchFilewith only untracked files returns metadata withWritten: falsego test ./internal/... ./cmd/...)