Stop sandbox when .git directory is missing during exec#390
Merged
Conversation
e5b8f37 to
aae798e
Compare
When syncChangesToSandbox detects a missing .git directory, the sandbox was left running and the session stayed in storage. Users had to manually reset before retrying. Now we send __rwx_sandbox_end__ and remove the session so the next exec gets a fresh sandbox automatically.
aae798e to
2a9f11a
Compare
jmsanders
approved these changes
Mar 2, 2026
kylekthompson
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox execdetects a missing.gitdirectory during sync, the sandbox is now stopped and the session removed from storagerwx sandbox resetbefore retryingErrSandboxNoGitDir) soExecSandboxcan identify the specific failure and clean up via the already-open SSH connectionTest plan
__rwx_sandbox_end__is sent and session is removed from storagepreserve-git-dir: true, runrwx sandbox exec, confirm it errors and the sandbox is stopped (next exec creates a fresh one)