Closed
Conversation
`AbstractSupplementaryFileContainer` and `DictSupplementaryFileContainer` are extended by a `delete_file()` method, that allows deleting files from them. Since different files may have the same content, references to the files contents in `DictSupplementaryFileContainer._store` are tracked via `_store_refcount`. A files contents are only deleted from `_store`, if all filenames referring to these these contents are deleted, i.e. if the refcount reaches 0.
…around Since `PyECMA376-2` doesn't have a documentation we can link to, we ignore missing reference warnings caused by this problem. The visibility of this workaround is improved by making it a `TODO` instead of a regular comment. Furthermore, it now links to the corresponding issue.
Now that we require `lxml-stubs`, we can remove the `type: ignore` coments from the `lxml` imports. To make mypy happy, many typehints are adjusted, mostly `etree.Element` -> `etree._Element`.
Now that we use `etree._Element` instead of `etree.Element` in our docstrings and type annotations, we don't need this workaround anymore.
Author
|
I guess I'll have to create a separate branch for this merge to resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.