adapter.http: remove and improve type: ignore comments#43
Merged
Frosty2500 merged 2 commits intofeature/http_apifrom Jun 20, 2024
Merged
adapter.http: remove and improve type: ignore comments#43Frosty2500 merged 2 commits intofeature/http_apifrom
type: ignore comments#43Frosty2500 merged 2 commits intofeature/http_apifrom
Conversation
Werkzeug 3.0.3 contains a fix for [1], so by requiring at least 3.0.3, we can remove unnecessary 'type: ignore' comments from the http adapter. [1]: pallets/werkzeug#2836
Remove 'type: ignore' comments now that we require werkzeug >=3.0.3 [1]. Furthermore, fix the type hint of `WSGIApp._get_slice()` and make two other 'type: ignore' comments more explicit. [1]: pallets/werkzeug#2836
c5a97e2 to
5191fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that werkzeug 3.0.3 has been released, which contains a fix for pallets/werkzeug#2836, we require werkzeug 3.0.3 as the minimum version and remove the
type: ignorecomments, that were introduced to work around this issue.Furthermore, fix the type hint of
WSGIApp._get_slice()and make two othertype: ignorecomments more explicit.