merge main in feature/http_api#37
Merged
Frosty2500 merged 6 commits intofeature/http_apifrom Jun 7, 2024
Merged
Conversation
We extract the compliance_tool into its own package, since the functionality is not needed in the general SDK anymore. The new aas-compliance-tool can be found [here](https://github.com/rwth-iat/aas-compliance-tool).
When we removed the schema files, we overlooked that JSON and XML serialization need them. We probably need to find a way of fetching them during runtime of the test to avoid having to host them in our repository.
This removes the JSON Schema and XSD files that stem from the aas-specs repository. Instead, this adds the logic in the CI to fetch these files at runtime. Furthermore, we skip the unittests that make use of the schema files when they do not exist.
This PR fixes the outdated `NOTICE`. While doing that, I `notice`d, that the years in the copyright strings were outdated as well, so I updated them (using the `/etc/scripts/set_copyright_year.sh`) In the future, we should create a recurring task that makes us update the years at least once a year. Maybe it should also become a task before publishing a new release? Fixes eclipse-basyx#196 Depends on eclipse-basyx#235
These are unsafe, according to mypy: error: Call to abstract method "__init__" of "DataSpecificationContent" with trivial body via super() is unsafe [safe-super]
Author
|
This has already been fixed in #38 |
Frosty2500
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.