adapter.http: implement AAS API submodel routes via redirects#27
Merged
jkhsjdhjs merged 1 commit intofeature/http_apifrom Mar 31, 2024
Merged
Conversation
The submodel routes of the AAS API `/shells/<aas_id>/submodels` are the same already implemented as the submodel API, so we return a redirect here, after checking that the AAS indeed has a reference to the requested submodel. `PUT` and `DELETE` are different, as we also have to update the AAS in this case, either by adding a new updated reference in case of a `PUT` request changes the submodel id, or by removing the submodel reference for `DELETE` requests.
76 tasks
s-heppner
approved these changes
Mar 28, 2024
Member
|
LGTM |
|
Also LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The submodel routes of the AAS API
/shells/<aas_id>/submodelsare the same already implemented as the submodel API, so we return a redirect here, after checking that the AAS indeed has a reference to the requested submodel.PUTandDELETEare different, as we also have to update the AAS in this case, either by adding a new updated reference in case of aPUTrequest changes the submodel id, or by removing the submodel reference forDELETErequests.