adapter.http: AAS SpecificAssetId filtering#23
Merged
s-heppner merged 2 commits intofeature/http_apifrom Apr 3, 2024
Merged
Conversation
39257db to
3c83221
Compare
jkhsjdhjs
suggested changes
Mar 20, 2024
jkhsjdhjs
left a comment
There was a problem hiding this comment.
This doesn't work, but the idea is correct. The changes required to make it work should be relatively simple.
Furthermore, I already rebased the branch to resolve conflicts that arose due to #22. Before you continue to work on this, you should do the following to remove the commit you have locally and pull the commit I rebased.
git reset --hard HEAD\^
git pull
76 tasks
Member
|
After you did what @jkhsjdhjs suggested, have a look at the StaticAnalysis Test on this page here: Other than that, the logic seems fine to me. |
8fddc50 to
5ec7766
Compare
e817fd3 to
a46a296
Compare
a46a296 to
216e5b3
Compare
SpecificAssetId filtering
e8368d5 to
a97201c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The procedure is as follows:
First, it ensures that we have an appropriate method in HTTPApiDecoder to handle decoding base64url-encoded strings into JSON and then into SpecificAssetId instances.
Finally, the modified get_aas_all function to use this new method for filtering based on SpecificAssetIds is like below: